deps: bump dependencies to latest #3552

jniles · 2019-01-22T10:23:07Z

This PR bumps all dependencies to their latest version, except ui-router, which has major breaking changes for both an upgrade and a downgrade.

The major changes are:

We removed all @bower_components and replaced them with their native NPM counterparts. This allows green-keeper to keep us up to date with different versions. The one exception to this is angular-ui-router, as mentioned above.
gulp has been upgraded to version 4! If there was a performance increase, it was small. However, this allows us to rewrite our gulpfile for better clarity.
A ton of unused CSS has been pruned. We don't use it anymore, so let us remove it.
All vendor references have been removed. We no longer use a vendor folder without bower.

Super awesome changes:

When using NODE_ENV=development, the application bundles the unminified dependencies. That means we have much better insight into what bugs are happening and less cryptic error message.

jniles · 2019-01-24T19:56:04Z

I jumped the gun a bit, and we are being blocked now by angular/angular.js#16814. We'll see if they release a new version with the bug patched soon.

Angular just released a bugfix build and we've upgraded to it. We've also taken the opportunity to officially bump the rest of the depends up to a supported version.

BREAKING CHANGE: a lot of third party files have been removed and put into node_modules so they can be downloaded instead of versioned in our repository. This breaks all developer builds until you download and re-install node_modules. The gulp build is cleaned up to remove files that were never accessible, adjust paths away from @bower_components to their npm version, and finally remove fonts from assets so they are also downloaded with yarn. This makes it easier to rationalize the package.json and to read the gulpfile. It also makes future upgrades to gulp (v4) easier to manage.

The build now minifies all CSS in production mode. Additionally, the issues with the weird animations have been solved by concatenating the scripts before minification, rather than after, so that the minifier doesn't create variable collisions. Finally, the ui-grid fonts now have a special gulp task because they are referred to as specially in the css directory. They have a special place in our hearts.

This commit links the barcode and CSS to make sure wkhtmltopdf doesn't report a network error when rendering. Integration tests now pass.

This commit upgrades the gulpfile to use Gulp Version 4. Closes IMA-WorldHealth#3327.

Adds the $applyAsync to tease out a performance boost on modules with many $http queries.

Updates to an angular version that actually works! :). Also fixes some typos in the build script and test script.

This commit fixes the modal by removing the appended classes from the ui-selects in the account reference modal. We needed to work around this by clicking to clear away from the context.

The ui-router master branch changes the order in which states are entered, which in turn breaks a lot of BHIMA. We'll need to do some major adjustments to our routing to get up to the latest and greatest ui-router.

…r-deps

The multiple depot component is no longer appended to the body to prevent issues with testing.

The bhMultipleCashboxSelect append-to-body tag has been removed to facilitate testing.

jniles · 2019-02-27T15:45:56Z

@mbayopanda, this is also finally ready for review.

…r-deps

mbayopanda

I made a comment about the angular-file-upload-bower dependency.

And also, i have got this error with font-awesome :

mbayopanda · 2019-03-04T17:34:51Z

client/src/js/app.js

@@ -203,6 +203,9 @@ function httpConfig($httpProvider) {

  // register error handling interceptor
  $httpProvider.interceptors.push('ErrorInterceptor');
+
+  // perf - applyAsync
+  $httpProvider.useApplyAsync(true);


Do we really need this ?

I found this comment

It's not clear if this will help or not, but I can imagine three places where this will help:

Typeaheads/validators (such as the hospital_no) will trigger less digest calls. We use these quite a bit in our application, shipping lots of small requests rapidly over a local network.

Modules where we add new grid rows to Stock/Vouchers/Transactions that prompt HTTP requests. For example, when we add voucher tools, those often trigger several HTTP requests from the Voucher module. This will stack those requests to make the browser do fewer $digest calls.

Each ui-grid cellTemplate seems to send an HTTP request. I'm not sure why - maybe we need to debug this somewhere, but for the moment, this might help.

Again, this might be a bad idea, but we have to try it to find out... from the documentation, it doesn't look like it will hurt anything, just might not help as much as we hope.

mbayopanda · 2019-03-04T17:40:19Z

client/src/js/services/NotifyService.js


  // default time to live of 3 seconds
-  var TTL = 3000;
+  const TTL = 1000000;


:-) i think the comment must also be updated.

A curiosity question, why this decision of using 1000 seconds now ?

Yup, you are right. This is a mistake, and I'll revert it.

mbayopanda · 2019-03-04T17:49:30Z

package.json

-    "angular": "angular/bower-angular#1.7.5",
-    "angular-animate": "angular/bower-angular-animate#1.7.5",
-    "angular-dynamic-locale": "lgalfaso/angular-dynamic-locale#0.1.37",
-    "angular-file-upload-bower": "danialfarid/angular-file-upload-bower#12.2.13",


Don't we need the angular-file-upload-bower anymore ?

Good question. It has been renamed ng-file-upload and is still included in the package.json file.

This is the old repository. You can in the README that they link to "angular-file-upload", but that it redirects to ng-file-upload.

And ng-file-upload is in line 92 of this file.

mbayopanda · 2019-03-04T17:49:51Z

server/controllers/finance/reports/ohada_profit_loss/index.js

@@ -296,7 +296,6 @@ function document(req, res, next) {
        return item;
      });

-      // console.log(assetTable);


mbayopanda · 2019-03-04T17:50:37Z

sh/test.sh

@@ -32,7 +32,7 @@ startfold "Running server Unit Tests ......" "server-unit"
 endfold "server-unit" ;

 # run end to end tests
-startfold "Running Client Unit Tests..." "test-end-to-end";
+startfold "Running Client End to End Tests..." "test-end-to-end";


👍 good catch

jniles · 2019-03-04T18:52:57Z

Thanks for the thorough review @mbayopanda.

About snyk - I'm not sure what is going on there, although I remember some issue with snyk in the past that was similar. Do the font-awesome icons load when you launch BHIMA?

mbayopanda · 2019-03-04T19:03:53Z

I cannot run the application correctly :

mbayopanda · 2019-03-04T19:06:51Z

With yarn there is not any errors during the yarn command

mbayopanda · 2019-03-04T19:09:16Z

Everything seems to work correctly and also the file upload

mbayopanda · 2019-03-04T19:10:42Z

Could you fix the mergin conflict so that i can merge it

…r-deps

mbayopanda · 2019-03-05T10:37:47Z

bors r+

3552: deps: bump dependencies to latest r=mbayopanda a=jniles This PR bumps all dependencies to their latest version, except ui-router, which has major breaking changes for both an upgrade and a downgrade. The major changes are: 1. We removed all `@bower_components` and replaced them with their native NPM counterparts. This allows green-keeper to keep us up to date with different versions. The one exception to this is angular-ui-router, as mentioned above. 2. `gulp` has been upgraded to version 4! If there was a performance increase, it was small. However, this allows us to rewrite our gulpfile for better clarity. 3. A ton of unused CSS has been pruned. We don't use it anymore, so let us remove it. 4. All `vendor` references have been removed. We no longer use a vendor folder without bower. Super awesome changes: 1. When using `NODE_ENV=development`, the application bundles the unminified dependencies. That means we have much better insight into what bugs are happening and less cryptic error message. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>

bors · 2019-03-05T11:01:21Z

Build failed

continuous-integration/travis-ci/push

mbayopanda · 2019-03-05T11:33:42Z

bors r+

3552: deps: bump dependencies to latest r=mbayopanda a=jniles This PR bumps all dependencies to their latest version, except ui-router, which has major breaking changes for both an upgrade and a downgrade. The major changes are: 1. We removed all `@bower_components` and replaced them with their native NPM counterparts. This allows green-keeper to keep us up to date with different versions. The one exception to this is angular-ui-router, as mentioned above. 2. `gulp` has been upgraded to version 4! If there was a performance increase, it was small. However, this allows us to rewrite our gulpfile for better clarity. 3. A ton of unused CSS has been pruned. We don't use it anymore, so let us remove it. 4. All `vendor` references have been removed. We no longer use a vendor folder without bower. Super awesome changes: 1. When using `NODE_ENV=development`, the application bundles the unminified dependencies. That means we have much better insight into what bugs are happening and less cryptic error message. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>

bors · 2019-03-05T11:56:23Z

Build succeeded

continuous-integration/travis-ci/push

jniles added the dependencies label Jan 22, 2019

jniles force-pushed the chore-bump-angular-deps branch from fa4916b to dd39b98 Compare January 24, 2019 19:50

jniles force-pushed the chore-bump-angular-deps branch from dd39b98 to b7e7f6e Compare January 24, 2019 20:06

jniles added the Breaking Change label Jan 25, 2019

jniles force-pushed the chore-bump-angular-deps branch 2 times, most recently from e9486fd to a8fe7a8 Compare February 4, 2019 13:49

jniles force-pushed the chore-bump-angular-deps branch 2 times, most recently from 2db4e3b to 97bf5dc Compare February 5, 2019 13:24

jniles added 9 commits February 7, 2019 13:18

deps: bump dependencies to latest

d90c1a8

Angular just released a bugfix build and we've upgraded to it. We've also taken the opportunity to officially bump the rest of the depends up to a supported version.

fix(build): link dependencies to unbreak wkhtmltopdf

1a042d9

This commit links the barcode and CSS to make sure wkhtmltopdf doesn't report a network error when rendering. Integration tests now pass.

chore: upgrade to gulp v4

73be4b5

This commit upgrades the gulpfile to use Gulp Version 4. Closes IMA-WorldHealth#3327.

perf: use $httpProvider.$applyAsync

dc06e7f

Adds the $applyAsync to tease out a performance boost on modules with many $http queries.

chore(deps): bump dependencies to get bug fixes

b2a7354

Updates to an angular version that actually works! :). Also fixes some typos in the build script and test script.

fix(account reference): remove appended uiSelects

46de1f6

This commit fixes the modal by removing the appended classes from the ui-selects in the account reference modal. We needed to work around this by clicking to clear away from the context.

fix(deps): download ui-router to legacy

6f4851c

The ui-router master branch changes the order in which states are entered, which in turn breaks a lot of BHIMA. We'll need to do some major adjustments to our routing to get up to the latest and greatest ui-router.

jniles force-pushed the chore-bump-angular-deps branch from c5b54d0 to 6f4851c Compare February 11, 2019 13:17

jniles added 5 commits February 11, 2019 15:16

Merge remote-tracking branch 'upstream/master' into chore-bump-angula…

f0efe79

…r-deps

Merge remote-tracking branch 'upstream/master' into chore-bump-angula…

e5e5716

…r-deps

Merge remote-tracking branch 'upstream/master' into chore-bump-angula…

77474fb

…r-deps

fix(depots): do not append to body

84c8f45

The multiple depot component is no longer appended to the body to prevent issues with testing.

fix(cashboxes): rm append multiple select to body

62e09d4

The bhMultipleCashboxSelect append-to-body tag has been removed to facilitate testing.

jniles requested a review from mbayopanda February 27, 2019 15:45

Merge remote-tracking branch 'upstream/master' into chore-bump-angula…

b901c5a

…r-deps

mbayopanda reviewed Mar 4, 2019

View reviewed changes

kwilu added the size: XL label Mar 5, 2019

Merge remote-tracking branch 'upstream/master' into chore-bump-angula…

1ac2a8e

…r-deps

jniles force-pushed the chore-bump-angular-deps branch from 643f8d7 to 1ac2a8e Compare March 5, 2019 08:38

bors bot merged commit 1ac2a8e into IMA-WorldHealth:master Mar 5, 2019

jniles deleted the chore-bump-angular-deps branch March 5, 2019 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: bump dependencies to latest #3552

deps: bump dependencies to latest #3552

jniles commented Jan 22, 2019 •

edited

jniles commented Jan 24, 2019

jniles commented Feb 27, 2019

mbayopanda left a comment

mbayopanda Mar 4, 2019

jniles Mar 4, 2019 •

edited

mbayopanda Mar 4, 2019

jniles Mar 4, 2019

mbayopanda Mar 4, 2019

jniles Mar 4, 2019

mbayopanda Mar 4, 2019

mbayopanda Mar 4, 2019

jniles commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 5, 2019

bors bot commented Mar 5, 2019

mbayopanda commented Mar 5, 2019

bors bot commented Mar 5, 2019

deps: bump dependencies to latest #3552

deps: bump dependencies to latest #3552

Conversation

jniles commented Jan 22, 2019 • edited

jniles commented Jan 24, 2019

jniles commented Feb 27, 2019

mbayopanda left a comment

Choose a reason for hiding this comment

mbayopanda Mar 4, 2019

Choose a reason for hiding this comment

jniles Mar 4, 2019 • edited

Choose a reason for hiding this comment

mbayopanda Mar 4, 2019

Choose a reason for hiding this comment

jniles Mar 4, 2019

Choose a reason for hiding this comment

mbayopanda Mar 4, 2019

Choose a reason for hiding this comment

jniles Mar 4, 2019

Choose a reason for hiding this comment

mbayopanda Mar 4, 2019

Choose a reason for hiding this comment

mbayopanda Mar 4, 2019

Choose a reason for hiding this comment

jniles commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 4, 2019

mbayopanda commented Mar 5, 2019

bors bot commented Mar 5, 2019

Build failed

mbayopanda commented Mar 5, 2019

bors bot commented Mar 5, 2019

Build succeeded

jniles commented Jan 22, 2019 •

edited

jniles Mar 4, 2019 •

edited