downgrade ajv back to 5.5.2, refs #2270 #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works fine on local test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a dependabot commit that upgraded the version of
ajvfrom 5.5.2 to 6.12.3: 01151a7This caused us to bump into this issue: ajv-validator/ajv#941
This caused the error mentioned in #2270 - currently unclear if it might also affect other parts of the site.
For now, this commit just reverts back to the version we were at - i.e. 5.5.2 . In the linked ticket, it seems this problem was introduced in
ajvin 6.9.0, so we can probably go to something like 6.8.0 .For now as a hotfix, I'd rather just roll-back to where we were, and we can upgrade to 6.8.0 in the normal release cycle accounting for testing, etc.
cc @szabozoltan69 @tovari @frozenhelium