refactor: isValidVersion readibility #2864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingCookieRookie
force-pushed
the
refactor/isValidVersion
branch
from
bccba1e
to
592fb85
Compare
hindessm
reviewed
Apr 18, 2024
fetch_request.go
Outdated
| @@ -281,7 +281,7 @@ func (r *FetchRequest) headerVersion() int16 { | |||
| } | |||
|
|
|||
| func (r *FetchRequest) isValidVersion() bool { | |||
There was a problem hiding this comment.
This is clearly not equivalent. I suspect you automated the fix and match incorrectly on <= 1 against <= 11? Personally I prefer the consistency of a range check in all the cases even when it is a simple range as it is easier to update (and easier to maintain when we switch to generating code from protocol json).
There was a problem hiding this comment.
Yes thanks for noticing, missed those during the automated fix for all, edited it. I see, sure that makes sense as well :)
CodingCookieRookie
force-pushed
the
refactor/isValidVersion
branch
from
592fb85
to
e08bfe7
Compare
Signed-off-by: alvin <bioluminescencecloud@gmail.com>
CodingCookieRookie
force-pushed
the
refactor/isValidVersion
branch
from
e08bfe7
to
9bc0c50
Compare
|
I’m unsure of the value of this change. There is no functional behavior change, and we lose the consistency to the version range checks elsewhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.