fix metadata disable full scan #2830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
famarting
force-pushed
the
fix-metadata-full-false
branch
from
e7dedc5
to
8f65c56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR address, but don't fix directly, this issues:
Metadata.Fullto false. #2069Also this will be of great help in Dapr: dapr/components-contrib#3247
With this changes now it will be possible to set
config.Metadata.Full = falsebut it would require the user to set a topic viaconfig.Metadata.InitialTopics = []string{"dummy-topic"}, with this the first request to fetch the metadata will either create that topic if it doesn't exist or it will just fetch its metadata