feat: add Delegation Token APIs to ClusterAdmin #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the KIP-48 APIs regarding token delegation to `ClusterAdmin`. These APIs have been available on Brokers since v1.1 and the Java AdminClient has had these facilities since v2.0. https://cwiki.apache.org/confluence/display/KAFKA/KIP-48+Delegation+token+support+for+Kafka Signed-off-by: Chris <chrissslee93@gmail.com>
Chrisss93
force-pushed
the
delegation-token-apis
branch
from
e104814
to
2958a30
Compare
dnwe
force-pushed
the
delegation-token-apis
branch
from
61d8d77
to
4c9da50
Compare
|
@Chrisss93 thanks for the contribution! A first pass review over the changes and they look good. One initial request, can we cover all the version options from v0, v1, v2, v3 (where appropriate) both in the
|
|
@Chrisss93 do you think you might be able to accommodate the above? |
dnwe
force-pushed
the
delegation-token-apis
branch
from
4c9da50
to
cfc3a20
Compare
dnwe
changed the title
dnwe
changed the title
dnwe
force-pushed
the
delegation-token-apis
branch
2 times, most recently
from
641d24a
to
fc430c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the KIP-48 APIs regarding token delegation to the
ClusterAdmin. These APIs have been available on brokers > v1.1 and the AdminClient in Java has had these facilities since v2.0.