Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fvt): fresh metrics registry for each test #2616

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix(fvt): fresh metrics registry for each test #2616

merged 2 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. fix(fvt): fresh metrics registry for each test 

    Trying to nail down flakiness with the verification of metrics in these
tests. Since adding the additional versions these have been flakey and I
think the reason is that the registry is getting re-used between tests
as it is only created fresh on a call to NewConfig

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d44ebdc View commit details
    Browse the repository at this point in the history

  2. fix(fvt): reduce minimum compression-ratio metric 

    Batched test compression-ratio can sometimes be as low as 3

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    827ec18 View commit details
    Browse the repository at this point in the history