fix: restore (*OffsetCommitRequest) AddBlock func #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v1.34.0 a breaking API change to (*OffsetCommitRequest) AddBlock was inadvertently introduced by 59a3d39 We weren't aware that anyone was driving the offset commit protocol directly via the broker.go call rather than via offset_manager.go (or via a consumer client) For now we restore the old AddBlock signature and move the new one to AddBlockWithLeaderEpoch. This will unfortunately impact anyone who had updated their own code to call the new func signature, but it's probably more important that we restore the longer term backwards compatibility now until we move to a v2 release. Fixes #2358 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
dnwe
force-pushed
the
dnwe/restore-offset-commit-addblock
branch
from
1d949d6
to
4b9e8f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.34.0 a breaking API change to (*OffsetCommitRequest) AddBlock was inadvertently introduced by 59a3d39
We weren't aware that anyone was driving the offset commit protocol directly via the broker.go call rather than via offset_manager.go (or via a consumer client)
For now we restore the old AddBlock signature and move the new one to AddBlockWithLeaderEpoch. This will unfortunately impact anyone who had updated their own code to call the new func signature, but it's probably more important that we restore the longer term backwards compatibility now until we move to a v2 release.
Fixes #2358