Allow to implement a custom SASL mechanism and deprecate the previous mechanism #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpaquet
force-pushed
the
add_custom_mechanism_v2
branch
from
263fa07
to
b7e3664
Compare
bpaquet
added a commit
to bpaquet/awsIamMskForSarama
that referenced
this pull request
Jun 29, 2023
dnwe
force-pushed
the
add_custom_mechanism_v2
branch
from
b7e3664
to
b23c96c
Compare
dnwe
force-pushed
the
add_custom_mechanism_v2
branch
from
b23c96c
to
3dfe043
Compare
|
Linked to: |
dnwe
force-pushed
the
add_custom_mechanism_v2
branch
from
3dfe043
to
111abfa
Compare
|
@dnwe Can I help to move forward with this PR? Thx |
dnwe
force-pushed
the
add_custom_mechanism_v2
branch
from
111abfa
to
c17edb1
Compare
This comment was marked as spam.
This comment was marked as spam.
|
This PR seems to be useless now, because of https://github.com/aws/aws-msk-iam-sasl-signer-go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dnwe This is a follow up of #2466
In this PR, I'm replacing the previous mechanisms
SCRAM-SHA-256andSCRAM-SHA-512by a generic functionSCRAMClientExternalwhich be used to implement custom auth mechanism, like AWS IAM MSK.This is a breaking change in the config API, as we discussed in the previous PR.
SCRAM-SHA-256andSCRAM-SHA-512can be implemented with the new API (seeexamples/sasl_scram_client/main.go).Implementation of the custom mechanism for AWS IAM MSK: https://github.com/bpaquet/awsIamMskForSarama
Using it in kaf: https://github.com/bpaquet/kaf/tree/msk_iam_3