Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(producer): replace time.After with time.Timer to avoid high memory usage #2355

Merged
merged 1 commit into from Oct 4, 2022
Merged

fix(producer): replace time.After with time.Timer to avoid high memory usage #2355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions async_producer.go
View file
Open in desktop
Expand Up @@ -891,7 +891,7 @@ type brokerProducer struct {
abandoned chan struct{}

buffer *produceSet
timer <-chan time.Time
timer *time.Timer
timerFired bool

closing error
Expand All @@ -900,6 +900,7 @@ type brokerProducer struct {

func (bp *brokerProducer) run() {
var output chan<- *produceSet
var timerChan <-chan time.Time
Logger.Printf("producer/broker/%d starting up\n", bp.broker.ID())

for {
Expand Down Expand Up @@ -969,12 +970,14 @@ func (bp *brokerProducer) run() {
}

if bp.parent.conf.Producer.Flush.Frequency > 0 && bp.timer == nil {
bp.timer = time.After(bp.parent.conf.Producer.Flush.Frequency)
bp.timer = time.NewTimer(bp.parent.conf.Producer.Flush.Frequency)
timerChan = bp.timer.C
}
case <-bp.timer:
case <-timerChan:
bp.timerFired = true
case output <- bp.buffer:
bp.rollOver()
timerChan = nil
case response, ok := <-bp.responses:
if ok {
bp.handleResponse(response)
Expand Down Expand Up @@ -1034,6 +1037,9 @@ func (bp *brokerProducer) waitForSpace(msg *ProducerMessage, forceRollover bool)
}

func (bp *brokerProducer) rollOver() {
if bp.timer != nil {
bp.timer.Stop()
}
bp.timer = nil
bp.timerFired = false
bp.buffer = newProduceSet(bp.parent)
Expand Down