Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(consumer): default ResetInvalidOffsets to true #2345

Merged
merged 1 commit into from Sep 27, 2022
Merged

fix(consumer): default ResetInvalidOffsets to true #2345

merged 1 commit into from Sep 27, 2022

Commits on Sep 27, 2022

  1. fix(consumer): default ResetInvalidOffsets to true 

    A number of people have reported issues with the change in default
behaviour that was introduced in #2252 and the comment for this
configuration value had suggested it would retain the behaviour of
previous Sarama versions. This PR puts the default behaviour back to
resetting to `c.Consumer.Offsets.Initial` when the server returns an out
of range error on a Fetch.

Contributes-to: #2342
    @dnwe
    dnwe committed Sep 27, 2022
    Copy the full SHA
    d2ee3e1 View commit details
    Browse the repository at this point in the history