Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIP-42 Add producer and consumer interceptors #1730

Merged
merged 6 commits into from Jul 15, 2020
Merged

KIP-42 Add producer and consumer interceptors #1730

merged 6 commits into from Jul 15, 2020

Commits on Jun 29, 2020

  1. KIP-42 Add producer and consumer interceptors 

    This PR includes:
Producer: `onSend` but it doesn't implement `onAcknowledgement`
Consumer: `onConsume` but it doesn't implement `onCommit`

I'm not sure if I need to add the `onClose` method. Maybe in another
iteration ¯\_(ツ)_/¯
    @d1egoaz
    d1egoaz committed Jun 29, 2020
    Copy the full SHA
    5d05ad6 View commit details
    Browse the repository at this point in the history

  2. make linter happy

    @d1egoaz
    d1egoaz committed Jun 29, 2020
    Copy the full SHA
    aff81da View commit details
    Browse the repository at this point in the history

  3. remove code comments

    @d1egoaz
    d1egoaz committed Jun 29, 2020
    Copy the full SHA
    2beebdf View commit details
    Browse the repository at this point in the history

  4. use the third person singular present tense 

    s/have/has
    @d1egoaz
    d1egoaz committed Jun 29, 2020
    Copy the full SHA
    76f08b8 View commit details
    Browse the repository at this point in the history

  5. export interceptor methods

    @d1egoaz
    d1egoaz committed Jun 29, 2020
    Copy the full SHA
    a299948 View commit details
    Browse the repository at this point in the history

  6. fix renamed variable after merging latest master

    @d1egoaz
    d1egoaz committed Jun 29, 2020
    Copy the full SHA
    899e856 View commit details
    Browse the repository at this point in the history