wip: add basic mocks for consumer group responses #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
carldunham
force-pushed
the
cd/1577/consumer-group-mocks
branch
2 times, most recently
from
f549c07
to
6c43add
Compare
carldunham
changed the title
carldunham
force-pushed
the
cd/1577/consumer-group-mocks
branch
from
6c43add
to
e81f001
Compare
| } | ||
| } | ||
|
|
||
| func (m *MockJoinGroupResponse) For(reqBody versionedDecoder) encoder { |
There was a problem hiding this comment.
return type should be encodeWithHeader
|
I think this PR is already solved by #1750 ? |
|
Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some response mocks:
Wasn't quite sure where to put unit tests for these, if they are needed.
Addresses #1577