Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of MockJoinGroupResponse in mockresponses.go #1577

Closed
liuxin-reg opened this issue Jan 16, 2020 · 7 comments
Closed

Lack of MockJoinGroupResponse in mockresponses.go #1577

liuxin-reg opened this issue Jan 16, 2020 · 7 comments
Labels
stale Issues and pull requests without any recent activity

Comments

@liuxin-reg
Copy link

master
I haven't found struct MockJoinGroupResponse in mockresponses.go, will we support that?

@liuxin-reg
Copy link
Author

I have supplement some kind of mock responses to make group consumer work, but not enough to submit a commit. Will try and continue working on it.

@carldunham
Copy link

@liuxin-reg any luck with this? Happy to help out if you want.

@carldunham
Copy link

I submitted a PR with a few mocks, but I think consumer group mocking will take a bit more than just that.

@liuxin-reg
Copy link
Author

@carldunham Thanks for your response and PR. I had add some basic mocks for consumer group responses too, it can works now, but without enough detailed considerations contained. Now, I removed this modification from folder vendor, since I don't think this kind of mock is necessary for normal consumer client.

@gunturaf
Copy link

gunturaf commented Jun 8, 2020

Any updates on this one @carldunham @liuxin-reg ?

@ghost
Copy link

ghost commented Mar 16, 2021

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the master branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.

@ghost ghost added the stale Issues and pull requests without any recent activity label Mar 16, 2021
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
@dnwe
Copy link
Collaborator

dnwe commented Aug 24, 2023

Fixed by #1750

@dnwe dnwe closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues and pull requests without any recent activity
Projects
None yet
Development

No branches or pull requests

4 participants