Merge pull request #1846 from wclaeys/master

Do not ignore Consumer.Offsets.AutoCommit.Enable config on Close
IBM · Jan 13, 2021 · ceadf4f · ceadf4f
2 parents 80667b9 + 2b925af
commit ceadf4f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/offset_manager.go b/offset_manager.go
@@ -113,10 +113,12 @@ func (om *offsetManager) Close() error {
 		om.asyncClosePOMs()
 
 		// flush one last time
-		for attempt := 0; attempt <= om.conf.Consumer.Offsets.Retry.Max; attempt++ {
-			om.flushToBroker()
-			if om.releasePOMs(false) == 0 {
-				break
+		if om.conf.Consumer.Offsets.AutoCommit.Enable {
+			for attempt := 0; attempt <= om.conf.Consumer.Offsets.Retry.Max; attempt++ {
+				om.flushToBroker()
+				if om.releasePOMs(false) == 0 {
+					break
+				}
 			}
 		}