Skip to content

Commit

Permalink
Remove redundant hard-coding of env.KafkaVersion
Browse files Browse the repository at this point in the history
  • Loading branch information
KJTsanaktsidis authored and d1egoaz committed Jun 29, 2020
1 parent eb8dd50 commit 43af7c8
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions functional_test.go
Expand Up @@ -153,11 +153,6 @@ func prepareDockerTestEnvironment(ctx context.Context, env *testEnvironment) err
env.KafkaBrokerAddrs = append(env.KafkaBrokerAddrs, fmt.Sprintf("127.0.0.1:%d", 29090+i))
}

// the mapping of confluent platform docker image vesions -> kafka versions can be
// found here: https://docs.confluent.io/current/installation/versions-interoperability.html
// We have cp-5.5.0 in the docker-compose file, so that's kafka 2.5.0.
env.KafkaVersion = "2.5.0"

// Wait for the kafka broker to come up
allBrokersUp := false
for i := 0; i < 45 && !allBrokersUp; i++ {
Expand Down

0 comments on commit 43af7c8

Please sign in to comment.