fix: temporarily disable gzipping until axios bug fix is released #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 96.17% 96.16% -0.01%
==========================================
Files 7 7
Lines 418 417 -1
Branches 125 124 -1
==========================================
- Hits 402 401 -1
Misses 15 15
Partials 1 1
Continue to review full report at Codecov.
|
esminerva
approved these changes
May 17, 2019
|
🎉 This PR is included in version 0.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
204responses (no content) get flagged as errors becauseaxioschokes when it tries to unzip an empty response.A fix for this bug has been merged (see PR) but has not been released yet. Since it looks like
axiosis not doing patch releases for bug fixes right now but is waiting for their next big release (0.19), we need to temporarily disable gzipping in the SDK.We could do this only for operations that return a 204 but that would require generator changes so I think that would be more work than necessary, considering a fix for the bug seems to be in the somewhat near future.
If someone thinks that it would be worth it to do that, I'm happy to do it. Just let me know