Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Changes to Demo notebook from Rebased notebook branch #89

Merged
merged 6 commits into from May 13, 2024

Conversation

Bytes-Explorer
Copy link
Collaborator

Why are these changes needed?

Documentation changes to the notebook.

@blublinsky
Copy link
Collaborator

Is this a replacement for #80?

daw3rd and others added 3 commits May 9, 2024 13:48
Signed-off-by: David Wood <dawood@us.ibm.com>
Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
Signed-off-by: himapatel <himapatel@in.ibm.com>
@shivdeep-singh-ibm
Copy link
Collaborator

Some APIs are based on old codebase. Need to repush the notebook with new apis

Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
@daw3rd
Copy link
Member

daw3rd commented May 10, 2024

There are more changes pending/merged in PR #106 .

Added section fore xample notebook.

Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
Copy link
Collaborator

@shivdeep-singh-ibm shivdeep-singh-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shivdeep-singh-ibm
Copy link
Collaborator

There are more changes pending/merged in PR #106 .

updated notebook to include imports from latests paths as updated in#PR106

@shivdeep-singh-ibm shivdeep-singh-ibm marked this pull request as ready for review May 13, 2024 14:51
2. After dependancies are installed, we can launch the jupyter notebook

`make jupyter`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we suggest a zip file for use? Petros used our repo. Maybe that can work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is a good starting point till we get data approved.

@daw3rd daw3rd merged commit 489bec8 into dev May 13, 2024
11 checks passed
@shivdeep-singh-ibm shivdeep-singh-ibm deleted the rebased-notebook branch May 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants