Add missing functions to data_prep_toolkit_kfp lib #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Revital Sur <eres@il.ibm.com>
blublinsky
reviewed
May 12, 2024
| :return: Server response object containing pipleine id and other information. | ||
| """ | ||
| try: | ||
| p = self.kfp_client.upload_pipeline(pipeline_package_path, pipeline_name, description) |
There was a problem hiding this comment.
Do you need to check whether pipeline with the given name already exists? And remove the old one?
There was a problem hiding this comment.
This functionality is implemented in the https://github.com/IBM/data-prep-kit/blob/dev/kfp/kfp_support_lib/src/kfp_support/workflow_support/utils/pipelines_tests_utils.py#L6 file that already exists in the library.
There was a problem hiding this comment.
would it be cleaner to move this functionality here? With additional flag to overwrite or fail?
There was a problem hiding this comment.
Sure, will try to move the implementation. Thanks
There was a problem hiding this comment.
@blublinsky I changed the function as you suggested. Please review again. Thanks
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Boris Lublinsky <blublinsky@ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
blublinsky
reviewed
May 13, 2024
Signed-off-by: Revital Sur <eres@il.ibm.com>
Closed
Signed-off-by: Revital Sur <eres@il.ibm.com>
roytman
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing functions to workflow_utils.py file in data_prep_toolkit_kfp lib
/closes #93