Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add axios ^0.26.1 as a peer dependency #511

Merged
merged 1 commit into from Oct 5, 2022
Merged

Add axios ^0.26.1 as a peer dependency #511

merged 1 commit into from Oct 5, 2022

Conversation

mojito317
Copy link
Contributor

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Related to #510

Approach

Added axios<1.0.0 temporarily to the peerDependencies until axios/axios#5000 is not resolved.

Schema & API Changes

  • "No change"

Security and Privacy

  • "No change"

Testing

Unit tests passing after these steps:

rm package-lock.json
rm -rf node_modules
npm install <-- will install axios version 0.26.1 that does not have the bug
npm run unit

Monitoring and Logging

  • "No change"

@mojito317 mojito317 self-assigned this Oct 5, 2022
ricellis
ricellis approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@ricellis ricellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 small nit

CHANGES.md Outdated Show resolved Hide resolved
@mojito317 mojito317 merged commit 87309a6 into main Oct 5, 2022
@mojito317 mojito317 deleted the 510-hot-fix branch October 5, 2022 11:02
@mojito317 mojito317 added this to the 2.next milestone Oct 5, 2022
@ricellis ricellis mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricellis ricellis ricellis approved these changes

Assignees

@mojito317 mojito317

Labels
None yet
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mojito317 @ricellis