-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang version to 1.17 #245
Conversation
.secrets.baseline
Outdated
@@ -3,7 +3,7 @@ | |||
"files": "stubs/.+\\.json|go.sum|^.secrets.baseline$", | |||
"lines": null | |||
}, | |||
"generated_at": "2021-12-22T14:20:39Z", | |||
"generated_at": "2022-02-04T14:56:37Z", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If none has changed the baseline file, we do not need to regenerate it.
Technically this works, but let's wait with merging till 1.18 officially released https://tip.golang.org/doc/go1.18 |
7a40d81
to
9ce507e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, but maybe revert silly .secrets.baseline
file, it doesn't seems to have meaningful changes?
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
@@ -21,7 +21,7 @@ assignees: '' | |||
|
|||
**Must gather (please complete the following information):** | |||
- SDK Version [e.g. 1.2.1] | |||
- Go Version [e.g. Go 1.16.8] | |||
- Go Version [e.g. Go 1.17] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change this file here, it's going to be reverted on the next generated PR. Please do this change in the generator repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened PR in sdks repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in 8110401
README.md
Outdated
@@ -99,7 +99,7 @@ project: | |||
service instance or a | |||
[CouchDB](https://docs.couchdb.org/en/latest/install/index.html) | |||
server. | |||
- Go version 1.16 or 1.17. | |||
- Go version 1.17 or 1.18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this in advance the fix of https://github.com/IBM/cloudant-go-sdk/pull/245/files#r834610384
ed7f265
to
61de2b3
Compare
61de2b3
to
ca638f5
Compare
PR summary
Fixes: #242
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
Golang minimum version is 1.16
What is the new behavior?
Update minimum supported Golang version to 1.17
Does this PR introduce a breaking change?
Other information