Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Actions instead of Travis CI #50

Merged
merged 2 commits into from Sep 21, 2021
Merged

Use GitHub Actions instead of Travis CI #50

merged 2 commits into from Sep 21, 2021

Conversation

ind1go
Copy link
Member

@ind1go ind1go commented Sep 21, 2021

Moves to a workflow, analogous 馃 with the previous Travis CI configuration.

Note: currently uses @bjhargrave's fix to actions/setup-java#200 to deal with GPG subkeys. Revert to actions/setup-java@v2 once that is merged.

@ind1go
Use GitHub Actions for build instead of Travis CI
69da0e5 
Signed-off-by: Ben Cox <1038350+ind1go@users.noreply.github.com>
@ind1go
Remove duplicate license file
fcb0077 
Signed-off-by: Ben Cox <1038350+ind1go@users.noreply.github.com>
ind1go
ind1go commented Sep 21, 2021
View reviewed changes
.github/workflows/maven-build.yml
uses: actions/checkout@v2

- name: Setup Java
uses: bjhargrave/setup-java@a1600c1f88a7741e2420b0a657f2838cec4f09c5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When upstream action is fixed, change this to:

uses: actions/setup-java@v2

@stewartfrancis
Copy link
Member

I notice we're no longer using the settings.xml which sets the properties gpg.keyname and gpg.passphrase, which seem like default variable names used by the maven-gpg-plugin. Are they getting set by some other mechanism now? I couldn't find any reference to the gpg plugin using environment variables in its documentation

@ind1go
Copy link
Member Author

ind1go commented Sep 21, 2021

I notice we're no longer using the settings.xml which sets the properties gpg.keyname and gpg.passphrase, which seem like default variable names used by the maven-gpg-plugin. Are they getting set by some other mechanism now? I couldn't find any reference to the gpg plugin using environment variables in its documentation

That's right, the settings.xml is constructed by the setup-java action. You can find more info on the GPG bit in particular here.

@stewartfrancis
Copy link
Member

Well that's quite nice isn't it! lgtm!

@stewartfrancis
Copy link
Member

To be clear - I think we should go ahead and merge this, switching this repo over to GH actions

@ind1go
Copy link
Member Author

ind1go commented Sep 21, 2021

Well in that case... 馃敟 馃敟 馃敟 馃敟

@ind1go
Copy link
Member Author

ind1go commented Sep 21, 2021

Checks switched - we just need your official review.

@ind1go ind1go merged commit a7d89e1 into IBM:main Sep 21, 2021
@ind1go ind1go deleted the action-ibm branch September 21, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davenice davenice davenice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ind1go @stewartfrancis @davenice