Implement all_children for unbounded integers
#3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybug
force-pushed
the
all-children-unbounded-integers
branch
from
0e0d26a
to
81898d2
Compare
|
looks like the pandas coverage is still flaky? https://github.com/HypothesisWorks/hypothesis/actions/runs/9048944880/job/24862536263?pr=3983 I'm 98% sure the merge target here is latest master. |
Zac-HD
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3974. Turns out this definitely can happen in practice!
The reproducer in the issue is actually the worst case for this bug. Conditions for triggering are a strategy with a single unbounded
st.integersstrategy as the heaviest (or only) branching point in its choice tree. I'm guessing we're saturating the 8 and/or 16 bit integer buckets and then getting unlucky by trying to draw from said buckets 10 times in a row, triggering our deduplication fallback to exhaustive enumeration.