Support attrs alias
and private attributes in st.builds
#3807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3791.
More generally, adds support for attr's alias parameter. On master, the following errors, for instance:
Attrs also helpfully fills in
alias
with the correctly-stripped version of private attributes, which is why this fixes the linked issue.attrs only added
alias
in22.2.0
. I probably could have thrown aif attrs.__version__
in here and made things backwards compatible, but it would have complicated things, so I've taken the easier option of bumping the dependency. There is precedence for this, but if this is a tough sell I can work on continuing to support previous versions.P.S. I thought I would take a small break from IR pulls to do some good ol' bug fixing. I'm continuing to work on migrating the datatree to the IR, though! 馃檪