Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceback-trimming of contextlib under Python 3.11 #3326

Closed

Conversation

Cheukting
Copy link
Contributor

Trimming contextlib traceback for Python 3.11

closes #3298

@Zac-HD
Copy link
Member

Zac-HD commented May 1, 2022

If you want to fill out the release notes (e.g. "This patch by Cheuk Ting Ho improves traceback trimming on Python 3.11 prereleases (:issue:`3298`).") and delete the test skip, I'm happy to merge this as an interim measure.

assert sys.version_info.releaselevel == "alpha"
# TODO: our traceback elision doesn't work with Python 3.11's nice new format yet
collect_ignore_glob.append("cover/test_traceback_elision.py")
collect_ignore_glob.append("pytest/test_capture.py")

@Zac-HD
Copy link
Member

Zac-HD commented May 3, 2022

Thanks so much for working on this at the sprints today Cheuk! After talking to some core devs, we're going to wait until this is fixed upstream in beta 1.

@Zac-HD Zac-HD closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get traceback-trimming working under Python 3.11
2 participants