Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops python3.6 support #3192

Merged
merged 12 commits into from
Dec 22, 2021
Merged

Drops python3.6 support #3192

merged 12 commits into from
Dec 22, 2021

Conversation

sobolevn
Copy link
Member

I am pretty sure that I haven't covered all possible cases in this PR at the moment.
But, I hope that this is a good start 🙂

Any feedback is welcome!

Closes #3174

@sobolevn sobolevn requested review from Zac-HD and DRMacIver and removed request for Zac-HD December 11, 2021 14:51
@Zac-HD Zac-HD self-assigned this Dec 12, 2021
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm looking forward to merging this on the 23rd 😁

I've left some comments from looking through the diff, primarily about missed-refactorings around importlib.resources and the types defined in compat.py, and pushed a commit based on my manual audit of git grep -nE "[pP]y(thon)? ?3|sys\.version" -- . ':!*/changes.rst' results.

At some point I'll also want to check everything that we configure coverage to ignore, but that's pretty low priority.

hypothesis-python/docs/details.rst Outdated Show resolved Hide resolved
hypothesis-python/setup.py Show resolved Hide resolved
hypothesis-python/src/hypothesis/internal/compat.py Outdated Show resolved Hide resolved
hypothesis-python/src/hypothesis/provisional.py Outdated Show resolved Hide resolved
@sobolevn
Copy link
Member Author

Done, fixed all the things you've mentioned! Thanks a lot, @Zac-HD!

@Zac-HD
Copy link
Member

Zac-HD commented Dec 12, 2021

I hereby declare this finished! On EOL day, 2021-12-23, I'll approve and merge 🚀

@Zac-HD
Copy link
Member

Zac-HD commented Dec 12, 2021

If you're interested in putting some typing hacks back in support for new typing features in 3.9/3.10, we have #2978 and #2979 and arguably also #3150 😉

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Zac-HD Zac-HD merged commit fd1e927 into master Dec 22, 2021
@Zac-HD Zac-HD deleted the issue-3174 branch December 22, 2021 23:09
@sobolevn
Copy link
Member Author

Congrats! 🚀

Unrelated, but, mypy 0.930 was released, let me know if there are any regressions / new things to fix in hypothesis! 👍

@Zac-HD
Copy link
Member

Zac-HD commented Dec 23, 2021

I just rebuilt #3197 with the new versions of mypy, black, and shed! Moved some type-ignores around but it's a pretty small change 😎

Best new things to fix are, well, pick an issue! The typing ones in particular might suit you?

@sobolevn
Copy link
Member Author

#2978 is still in my backlog 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.6 at end of life (2021-12-23)
2 participants