-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drops python3.6 support #3192
Drops python3.6 support #3192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm looking forward to merging this on the 23rd 😁
I've left some comments from looking through the diff, primarily about missed-refactorings around importlib.resources
and the types defined in compat.py
, and pushed a commit based on my manual audit of git grep -nE "[pP]y(thon)? ?3|sys\.version" -- . ':!*/changes.rst'
results.
At some point I'll also want to check everything that we configure coverage
to ignore, but that's pretty low priority.
Done, fixed all the things you've mentioned! Thanks a lot, @Zac-HD! |
✅I hereby declare this finished! On EOL day, 2021-12-23, I'll approve and merge 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Congrats! 🚀 Unrelated, but, mypy 0.930 was released, let me know if there are any regressions / new things to fix in hypothesis! 👍 |
I just rebuilt #3197 with the new versions of mypy, black, and shed! Moved some type-ignores around but it's a pretty small change 😎 Best new things to fix are, well, pick an issue! The typing ones in particular might suit you? |
#2978 is still in my backlog 😎 |
I am pretty sure that I haven't covered all possible cases in this PR at the moment.
But, I hope that this is a good start 🙂
Any feedback is welcome!
Closes #3174