Predicate rewriting for nonempty collections #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
rewrite-string-list-filters
branch
4 times, most recently
from
ac76a34
to
19f79da
Compare
Zac-HD
force-pushed
the
rewrite-string-list-filters
branch
2 times, most recently
from
0dab910
to
1e9983b
Compare
Zac-HD
force-pushed
the
rewrite-string-list-filters
branch
from
1e9983b
to
d6f71e3
Compare
This was referenced Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further work on filter-rewriting as part of #2701. This is honestly not a huge patch, but it's of reviewable size and cleanly sets up for future work on e.g.
text().filter(str.isascii)orisidentifier.