Wrap array_shapes in @defines_strategy #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honno
force-pushed
the
honno/wrap-array-shapes
branch
from
37ab9cb
to
b846a6b
Compare
|
For the changelog, defines_strategy is not public api, so just say eg "This patch fixes the repr of array_shapes" Plus make that a proper cross reference (and note for future - for rst monospace you need double backticks). |
Zac-HD
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3067 I wrapped all the strategies in
array_helpers.pyin@defines_strategy()... exceptarray_shapes🤦♂️ 🤦♀️ 🤦I would write a test for this, but if the idea is to only have one place testing
array_helpers.pystuff then this is covered in #3065 (how I caught this).