Use @proxies instead of deepcopy for mutated array helpers #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honno
force-pushed
the
honno/numpy-extra-proxies
branch
from
6bfdbde
to
758571f
Compare
python/typing#865 - CI fails under Python 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3067 @Zac-HD commented that mutating the helper methods docstrings should not effect the original method. I had used
copy.deepcopyfor this and thought I had tested it... but clearly not, as Sphinx generation in #3065 demonstrates 馃うThis PR simply wraps the
valid_tuple_axesandmutually_broadcastable_shapesstrategies in@proxiesbefore mutating their__doc__, replacing the use ofdeepcopy. I've tested this works whenextra.array_apialso interfaces with the array helpers.