Update pinned dependencies #3019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
create-pull-request/patch
branch
2 times, most recently
from
1706ebe
to
db817d2
Compare
Zac-HD
commented
Jun 14, 2021
| @@ -103,7 +103,7 @@ class HypothesisFixComplexMinMagnitude(VisitorBasedCodemodCommand): | |||
| METADATA_DEPENDENCIES = (cst.metadata.QualifiedNameProvider,) | |||
|
|
|||
| @m.call_if_inside( | |||
| m.Call(metadata=match_qualname("hypothesis.strategies.complex_numbers")) | |||
| m.Call(metadata=match_qualname("hypothesis.strategies.complex_numbers")) # type: ignore | |||
There was a problem hiding this comment.
This is a mypy bug, confusing m.Call with builtins.Call (which does't accept a metadata= kwarg).
hypothesis/extra/codemods.py:106: error: Unexpected keyword argument "metadata" for "Call"
...python3.8/site-packages/mypy/typeshed/stdlib/builtins.pyi:95: note: "Call" defined here
I think python/mypy#10617 is the same underlying bug.
| @@ -28,7 +28,7 @@ | |||
| import datetime as dt | |||
|
|
|||
| import pytz | |||
| from pytz.tzfile import StaticTzInfo | |||
| from pytz.tzinfo import StaticTzInfo # type: ignore # incomplete stubs | |||
There was a problem hiding this comment.
Unclear if this is meant to be public or not, but it's missing from the typeshed stubs and installing them complains with the same error. At minimum, mypy should not recommend installing stubs which are already installed! See also python/mypy#10645
Zac-HD
force-pushed
the
create-pull-request/patch
branch
from
ccce896
to
db817d2
Compare
Zac-HD
force-pushed
the
create-pull-request/patch
branch
from
db817d2
to
065b89b
Compare
This was referenced Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've closed this PR since the main change is to update
mypy, and I'd rather do that after some fixes for new bugs are released in the upcoming 0.910 version. When that's available, see master...Zac-HD:mypy-0.910 for the expected changes.The long-awaited part is improved inference for unions of covariant generics -
one_of(...)should then inferSearchStrategy[... | ...]with the correct union of element types automatically, sinceExis a covariant typevar. See #1270 (comment) and the linked issues, plus python/mypy#9994 for the fix 馃榿If other typecheckers (e.g. pyright, pyre, pytype) don't handle this, we might want to (a) restore the overloads as a mitigation, and (b) add them to our CI so that we can detect future breakage for those users.