Make dictionaries(keys=sampled_from(...), ...) more efficient
#2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
efficient-sampled-dicts
branch
from
3378899
to
60b579d
Compare
Zac-HD
force-pushed
the
efficient-sampled-dicts
branch
2 times, most recently
from
dec50d3
to
e9dbf02
Compare
Zac-HD
force-pushed
the
efficient-sampled-dicts
branch
from
e9dbf02
to
a0ce679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2036, in that it extends our special-casing of unique lists of elements=sampled_from(), but not strictly part of that issue. Fortunately it also stands quite nicely alone, to be reviewed and merged separately 馃榿