Tiny internal refactorings #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
better-dedupe
branch
10 times, most recently
from
705fa94
to
ae779f7
Compare
|
Ping @HypothesisWorks/hypothesis-python-contributors for review? Note that CI won't pass on anything until we merge at least the update for |
rsokl
approved these changes
Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My experiments with making strategies hashable - to upgrade the de-duplication in
one_offrom avoiding unrolling recursive strategies forever to actual de-duplication - both concluded that while this was probably possible, it wasn't worth the effort.This PR adds a comment to the source explaining what's happening and why, for the benefit of future investigators, along with some minor cleanups I made along the way which seemed worth keeping.
Closes #2327 (as wontfix).