Generate longer strings for unsized dtypes #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsokl
requested changes
Dec 1, 2019
rsokl
approved these changes
Dec 1, 2019
Stranger6667
reviewed
Dec 1, 2019
| result = np.zeros( | ||
| shape=self.array_size, dtype=object if unsized_string_dtype else self.dtype | ||
| ) | ||
| print(self.dtype, result.dtype) |
There was a problem hiding this comment.
hm, seems like a debugging leftover :)
There was a problem hiding this comment.
Oh, darn... thanks for spotting this, I'll open a fixup pr 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #2229 (comment), we now do another little dance to get around Numpy's premature (in this case) allocation for strings of length one only. Closes #2229.