Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of Hypothesis example output #2240

Merged
merged 11 commits into from
Nov 29, 2019

Conversation

DRMacIver
Copy link
Member

This changes our printing logic to use the pretty printing library. This is partially to give nicer output, partially to give us a bit more control over how things are printed as setup for some later features...

While here I noted that the stateful testing library outputs a bunch of garbage from @given that is totally irrelevant to the user, and it was easier to fix that behaviour than fix the tests to assert the right things about its format, so I did that too.

@DRMacIver
Copy link
Member Author

I think the coverage problem is pointing to something dark and terrible being wrong in Hypothesis's handling of positional arguments. 😢

@DRMacIver DRMacIver changed the title Improve formatting of Hypothesis example output WIP: Improve formatting of Hypothesis example output Nov 28, 2019
@DRMacIver
Copy link
Member Author

I'm going to need to park this for some investigation of what the hell is up with positional arguments in @given and I should really be marking linear algebra instead of working on this.

@DRMacIver DRMacIver changed the title WIP: Improve formatting of Hypothesis example output Improve formatting of Hypothesis example output Nov 28, 2019
@DRMacIver
Copy link
Member Author

I think the coverage problem is pointing to something dark and terrible being wrong in Hypothesis's handling of positional arguments. 😢

Fortunately this turns out not to be the case. I still think there's probably something dark and terrible in there but I choose to ignore it for now.

@Zac-HD
Copy link
Member

Zac-HD commented Nov 29, 2019

I still think there's probably something dark and terrible in [handling of positional arguments] but I choose to ignore it for now.

Positional-only arguments, for example... but I'm also ignoring this until after the Py2/Hy5 transition. Or possibly #961 / #2231 😬

@DRMacIver DRMacIver merged commit f4f4693 into master Nov 29, 2019
@DRMacIver DRMacIver deleted the DRMacIver/nicer-printing branch November 29, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants