Implement booleans() and just() as sampled_from() for better collections
#2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
commented
Oct 6, 2019
DRMacIver
reviewed
Oct 7, 2019
Zac-HD
force-pushed
the
small-samples
branch
2 times, most recently
from
64a8766
to
f063f47
Compare
DRMacIver
reviewed
Oct 9, 2019
| return self.elements[0] | ||
|
|
||
| def __repr__(self): | ||
| return "just(%r)" % (value,) |
There was a problem hiding this comment.
self.value here?
(The build will tell you this anyway, but just to preempt it!)
DRMacIver
approved these changes
Oct 9, 2019
While kinda weird on the face of it, this makes generating unique collections a *lot* more efficient in certain unusual cases, and the overhead is roughly nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2031, we have some fancy handling for generating unique collections from some small known sequence of elements, i.e.
UniqueSampledListStrategyand the related filtering improvements.Now we take advantage of that logic for the common case that a strategy can only generate one (or perhaps two) elements. It's only a little more efficient on a per-case basis, but I was prompted by a
FilteringTooMuchwhile mucking around so here it is.