Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the check_type and check_valid_size validation functions #2084

Merged
merged 3 commits into from Sep 9, 2019
Merged

Improved the check_type and check_valid_size validation functions #2084

merged 3 commits into from Sep 9, 2019

Commits on Sep 9, 2019

  1. Improved the check_type and check_valid_size validation functions 

    A couple of minor improvements have been made:
- The check_type function now tests for lists of length 1 so the
returned mesaging is better.
- check_valid_size() now passes the name variable into check_type
as this is a required argument.

To cover the additional logic within check_type a new test has
been added in the test_validation file.
    @Zac-HD
    tg authored and Zac-HD committed Sep 9, 2019
    Copy the full SHA
    7177a65 View commit details
    Browse the repository at this point in the history

  2. Update test_validation.py

    @Zac-HD
    Zac-HD committed Sep 9, 2019
    Copy the full SHA
    6fd32b0 View commit details
    Browse the repository at this point in the history

  3. More efficient field names

    @Zac-HD
    Zac-HD committed Sep 9, 2019
    Copy the full SHA
    ef05f8f View commit details
    Browse the repository at this point in the history