Improve performance of generate_novel_prefix #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRMacIver
force-pushed
the
DRMacIver/generate-novel-prefix-performance
branch
from
90956bb
to
51ae1b2
Compare
DRMacIver
changed the title
Zac-HD
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2027
This is the performance patch I pulled from #2030 because it didn't seem necessary and changes the data distribution for some reason caused us to lose coverage.
I decided that the reason we lost coverage was mostly accidental - the previous tests couldn't reliably guarantee that coverage, they just happened to work - so I also added some tests for datetimes in this PR in order to get back to 100% coverage. I've also upped the
max_examplescount on one test that had become flaky, so I think there's some chance that this has made the data distribution slightly worse, but I think it's worth it for the performance gain.