Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate float sizes (min_size, max_size) #1635

Merged
merged 14 commits into from Oct 11, 2018
Merged

Deprecate float sizes (min_size, max_size) #1635

merged 14 commits into from Oct 11, 2018

Commits on Oct 10, 2018

  1. add deprecation notice for float sizes

    @math2001
    math2001 committed Oct 10, 2018
    Copy the full SHA
    c7982ce View commit details
    Browse the repository at this point in the history

  2. test deprecation notice for float sizes

    @math2001
    math2001 committed Oct 10, 2018
    Copy the full SHA
    b943f6b View commit details
    Browse the repository at this point in the history

  3. add test for floats sizes deprecations 

    min_size and max_size should be integers. And we only test whole float numbers,
like 5.0 for example.
    @math2001
    math2001 committed Oct 10, 2018
    Copy the full SHA
    61ad711 View commit details
    Browse the repository at this point in the history

  4. change type hints of average_size to None 

    It use to be type: int
    @math2001
    math2001 committed Oct 10, 2018
    Copy the full SHA
    63abdbe View commit details
    Browse the repository at this point in the history

  5. add myself to the contributors list

    @math2001
    math2001 committed Oct 10, 2018
    Copy the full SHA
    2ddb293 View commit details
    Browse the repository at this point in the history

  6. add relase.txt

    @math2001
    math2001 committed Oct 10, 2018
    Copy the full SHA
    4033c2b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. filter out deprecation warning during test 

    float size warning were breaking a test that was making sure that
invalid arguments raised an InvalidArgument error.
    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    70c208e View commit details
    Browse the repository at this point in the history

  2. fix formatting errors 

    lint and check-format tasks on travis
    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    dd255da View commit details
    Browse the repository at this point in the history

  3. fix pep8 linting error

    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    b3e63d6 View commit details
    Browse the repository at this point in the history

  4. fix max/min size valitation and roll back tests

    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    67ea919 View commit details
    Browse the repository at this point in the history

  5. updated release: add type hint infos 

    Thanks to @Zac-HD
    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    ea34ef0 View commit details
    Browse the repository at this point in the history

  6. remove use of average_size in examples

    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    ca46708 View commit details
    Browse the repository at this point in the history

  7. improve check_valid_size perf

    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    480c9c7 View commit details
    Browse the repository at this point in the history

  8. use % instead of .format in check_valid_size 

    Conforms to the rest of the document's style
    @math2001
    math2001 committed Oct 11, 2018
    Copy the full SHA
    956cbc3 View commit details
    Browse the repository at this point in the history