Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to our public API (PEPs 484 & 561) #1270

Merged
merged 9 commits into from
Jun 26, 2018
Merged

Add type hints to our public API (PEPs 484 & 561) #1270

merged 9 commits into from
Jun 26, 2018
+181 −27

Commits on Jun 25, 2018

  1. Document and distribute type hints

    @Zac-HD
    Zac-HD committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    0e637ce View commit details
    Browse the repository at this point in the history

  2. Add tests that type-checking works downstream

    @Zac-HD
    Zac-HD committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    44aa964 View commit details
    Browse the repository at this point in the history

  3. Current best-possible hint for one_of

    @Zac-HD
    Zac-HD committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    cdc2b97 View commit details
    Browse the repository at this point in the history

  4. Correct alphabet hint for text() 

    Note: need more validation to enforce this
    @Zac-HD
    Zac-HD committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    118ea90 View commit details
    Browse the repository at this point in the history

  5. Test type inference for recursive data

    @Zac-HD
    Zac-HD committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    47bf568 View commit details
    Browse the repository at this point in the history

  6. Make dict hint more useful in normal case

    @Zac-HD
    Zac-HD committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    2118a32 View commit details
    Browse the repository at this point in the history

  7. Comment on Mypy repr of recursion

    @Zac-HD
    Zac-HD committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    5f212e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2018

  1. Explictly name typed package 

    As suggested by Ethan Smith
    @Zac-HD
    Zac-HD committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    d643caf View commit details
    Browse the repository at this point in the history

  2. Add regex boundaries to make tests faster 

    The test could only pass if no padding was generated, so adding pattern boundaries makes matching faster and exact generation less flaky.
    @Zac-HD
    Zac-HD committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    03e1dd1 View commit details
    Browse the repository at this point in the history