Improve explain-mode performance #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
added
tests/build/CI
Zalathar
reviewed
Jun 9, 2021
Small improvements, but this is called very very often while we're tracing and so even micro-optimisations are worth it.
For two reasons: our analysis is just not relevant to deadline exceeded failures, and running under a tracer adds some non-representative slowdowns. Note that this code handles the case where we first discover an unrelated bug, start shrinking, and then find a deadline-exceeding input.
With shrinking disabled you get *a* result, but the "always observed for failing examples" part is pretty vacuous.
Zalathar
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches makes a few related changes to explain-mode, aimed at improving the test-time and user-facing performance. I think this is the best fix #2989 is going to get.
nocover(duh)__slots__and some micro-optimisations in theTracerclassDeadlineExceedederror is raised. The performance overhead of tracing interacts badly with deadlines, and "explaining" it in terms of some line of code is almost certainly wrong anyway.