Skip to content

Commit

Permalink
Explain mode requires shrinking
Browse files Browse the repository at this point in the history
With shrinking disabled you get *a* result, but the "always observed for failing examples" part is pretty vacuous.
  • Loading branch information
Zac-HD committed Jun 9, 2021
1 parent f2e3b4e commit 6efb67a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions hypothesis-python/RELEASE.rst
@@ -0,0 +1,4 @@
RELEASE_TYPE: minor

The :ref:`explain phase <phases>` now requires shrinking to be enabled,
and will be automatically skipped for deadline-exceeded errors.
1 change: 1 addition & 0 deletions hypothesis-python/src/hypothesis/core.py
Expand Up @@ -670,6 +670,7 @@ def _execute_once_for_engine(self, data):
if (
self.failed_normally
and not self.failed_over_deadline
and Phase.shrink in self.settings.phases
and Phase.explain in self.settings.phases
and sys.gettrace() is None
and not PYPY
Expand Down

0 comments on commit 6efb67a

Please sign in to comment.