Removed registration form, cleaned up login flow #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, and fast! I found three issues I think we can fix in this PR. On the front page we show a login button and you can signup with that form but I think the button should express that. Maybe "Login or Signup" when
The button back to the e-mail only login should take
The password reset form needs work as well.
|
|
@frjo great catches, thanks for taking a look! All should be resolved now, along with some CSS cleanup & addition translation tags added. It's weird stylelint flagged my variable use with that |
frjo
added
Type: Enhancement
frjo
force-pushed
the
enhancement/login-signup-improvements
branch
from
7f66695
to
f96cb89
Compare
frjo
added
Status: Needs testing
|
I rebased this PR and made some minor changes to text of a button. |
wes-otf
commented
Mar 21, 2024
| @@ -4,5 +4,5 @@ | |||
| href="{% url 'users:passwordless_login_signup' %}{% if next %}?next={{next}}{% endif %}" | |||
| > | |||
| {% heroicon_mini "envelope" size=18 class="inline align-text-bottom me-1" aria_hidden=true %} | |||
| {% trans "Log in " %}{% if ENABLE_PUBLIC_SIGNUP %} {% trans "or" %} {% trans "Sign in" %}{% endif %} {% trans "via" %} {% trans "e-mail" %} | |||
| {% trans "Log in without password" %} | |||
There was a problem hiding this comment.
I like this a lot better, should we indicate that this is where you would also go to signup though as that isn't given anywhere else?
There was a problem hiding this comment.
My thinking was that if you clicked your way to the password login form you are most likely not needing to create an account.
There was a problem hiding this comment.
fair enough, all good by me!
frjo
added
Type: Minor
wes-otf
added a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
Fixes HyphaApp#3813. Main changes: - [x] Got rid of the registration form in favor of using the `/auth/` view. Having two places where the user can potentially register is confusing. - [x] Cleaned up different aspects of the login flow that were mentioned in HyphaApp#3813, like inconsistency in terminology (`Login` vs `Log in`), removal of buttons where they don't need to be, etc. - [x] Added a button on the password-ed login to bring the user back to the passwordless log in/register view. - [x] Have buttons in column rather than row on *both* mobile & desktop view and made them the same width (`18 rem`). - Should we center the login page for desktop? This was done as it felt awkward to have everything on the left side while the buttons crept to the center - [x] Added icons to `Log in with <ORG> email` & `Log in or register via email` for consistency - [x] Moved login buttons to their own templates as some were being reused - [x] Added missing translation blocks
wes-otf
added a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
Fixes HyphaApp#3813. Main changes: - [x] Got rid of the registration form in favor of using the `/auth/` view. Having two places where the user can potentially register is confusing. - [x] Cleaned up different aspects of the login flow that were mentioned in HyphaApp#3813, like inconsistency in terminology (`Login` vs `Log in`), removal of buttons where they don't need to be, etc. - [x] Added a button on the password-ed login to bring the user back to the passwordless log in/register view. - [x] Have buttons in column rather than row on *both* mobile & desktop view and made them the same width (`18 rem`). - Should we center the login page for desktop? This was done as it felt awkward to have everything on the left side while the buttons crept to the center - [x] Added icons to `Log in with <ORG> email` & `Log in or register via email` for consistency - [x] Moved login buttons to their own templates as some were being reused - [x] Added missing translation blocks
wes-otf
added a commit
that referenced
this pull request
May 7, 2024
Fixes #3813. Main changes: - [x] Got rid of the registration form in favor of using the `/auth/` view. Having two places where the user can potentially register is confusing. - [x] Cleaned up different aspects of the login flow that were mentioned in #3813, like inconsistency in terminology (`Login` vs `Log in`), removal of buttons where they don't need to be, etc. - [x] Added a button on the password-ed login to bring the user back to the passwordless log in/register view. - [x] Have buttons in column rather than row on *both* mobile & desktop view and made them the same width (`18 rem`). - Should we center the login page for desktop? This was done as it felt awkward to have everything on the left side while the buttons crept to the center - [x] Added icons to `Log in with <ORG> email` & `Log in or register via email` for consistency - [x] Moved login buttons to their own templates as some were being reused - [x] Added missing translation blocks
wes-otf
added a commit
that referenced
this pull request
May 8, 2024
Fixes #3813. Main changes: - [x] Got rid of the registration form in favor of using the `/auth/` view. Having two places where the user can potentially register is confusing. - [x] Cleaned up different aspects of the login flow that were mentioned in #3813, like inconsistency in terminology (`Login` vs `Log in`), removal of buttons where they don't need to be, etc. - [x] Added a button on the password-ed login to bring the user back to the passwordless log in/register view. - [x] Have buttons in column rather than row on *both* mobile & desktop view and made them the same width (`18 rem`). - Should we center the login page for desktop? This was done as it felt awkward to have everything on the left side while the buttons crept to the center - [x] Added icons to `Log in with <ORG> email` & `Log in or register via email` for consistency - [x] Moved login buttons to their own templates as some were being reused - [x] Added missing translation blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3813. Main changes:
/auth/view. Having two places where the user can potentially register is confusing.LoginvsLog in), removal of buttons where they don't need to be, etc.18 rem).Log in with <ORG> email&Log in or register via emailfor consistencyScreenshots
Desktop Views
Homepage
Passwordless Login
Password-ed Login
Mobile Views
Homepage
Passwordless Login
Password-ed Login
Test Steps
Log inbutton appears in the top right cornerLog inbutton, and confirm you get taken to the passwordless login page (/auth/)Log in with passwordbutton and confirm you get taken to the password-ed page (/login/)Log in without password/auth/)