Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure of length #775

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Measure of length #775

wants to merge 13 commits into from

Conversation

JonasBarka
Copy link

@JonasBarka JonasBarka commented Jan 10, 2019

Fixes #526

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings Do not got ReSharper.
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution NA
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below). Based on latest master.
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

Note the interaction between parameters decimals and minPrefix as described in the comment to one of the unit tests.

Only maxPrefix and minPrefix are new options, but I added all options to the readme description of ToMetric.

@dnfclas
Copy link

dnfclas commented Jan 10, 2019

CLA assistant check
All CLA requirements met.

@clairernovotny clairernovotny changed the title fixes #526 Measure of length Jan 18, 2019
@@ -1,8 +1,8 @@
// Wrote by Alois de Gouvello https://github.com/aloisdg
// Written by Alois de Gouvello https://github.com/aloisdg with additions by Jonas Barkå https://github.com/JonasBarka.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyrights at the top of the file, if any, should be simply Copyright (c) .NET Foundation and Contributors

Alternatively, it can be removed as it's in the project root.


// The MIT License (MIT)

// Copyright (c) 2015 Alois de Gouvello
// Copyright (c) 2015-2019 Alois de Gouvello and each other contributor for their respective work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@SimonCropp
Copy link
Collaborator

@JonasBarka do you still want this one merged? if so can you address the comments and rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Measure of length
4 participants