ByteSize - implement IEEE conformity. fixes #592 #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exception on null and empty values, just like other TryParse methods
Added tests & fixed the double comparison assertions Corrected the symbol for kibibytes to use a capital K
|
Discussing this on #657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the ByteSize classes so they now conform to the IEEE 1541 standard, i.e. 1 kilobyte = 1000 bytes instead of 1024 bytes. Also added the IEC prefixes; kibi-, mebi-, gibi-, and tebi-, where 1 kibibyte = 1024 bytes etc. in the same manner as the kilo- prefixes worked before.
Added parsing support for negative byte amounts.
Made TryParse return false instead of throwing an exception when given null or whitespace input, so it works like other TryParse-methods.