fix DateOnly has current date return 'today'

[AJacksonCT]

fixes #1186 DateOnly has current date return 'today'

Here is a checklist you should tick through before submitting a pull request:

[x ] Implementation is clean
[ x] Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
[x ] No Code Analysis warnings
[x ] There is proper unit test coverage
If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
[x ] There are very few or no comments (because comments shouldn't be needed if you write clean code)
[x ] Xml documentation is added/updated for the addition/change
[x ] Your PR is (re)based on top of the latest commits from the main branch (more info below)
[x ] Link to the issue(s) you're fixing from your PR description. Use fixes #
[x ] Readme is updated if you change an existing feature or add a new one
[x ] Run either build.cmd or build.ps1 and ensure there are no test failures

[hazzik]

Imho, the changes to DateTime behaviour are not really expected.

[SimonCropp]

i agree with @hazzik. closing this one.

@ AJacksonCT if you still want this approach, can you re submit as an opt in approach

[AJacksonCT]

Not quite sure what happened here. This project had a call out for help. I submitted a PR for the work you were looking for. I have no concern whether or not this goes forward.

[SimonCropp]

ok after re-reading the issue more closely i think i was mistaken in closing this. since dateonly has no time component, it is incorrect to use the phrasing "from now" since that incorrectly implies an instance in time. in english a dateonly for the current date is literally "today".

@hazzik thoughts?

[hazzik]

@SimonCropp @AJacksonCT I have no objection to fix DateOnly humanization behavior and return “from today” as it makes more sense than “from now” in DateOnly context. However, as the original issue mentioned DateOnly uses DateTime algorithm which makes it tricky. And it seems that this PR changes the algorithm for not only DateOnly, but also for DateTime.

I have not seen the discussion around changing behavior for DateTime for days and over to use “from today” instead of “from now”.

[SimonCropp]

@AJacksonCT thoughts?

[SimonCropp]

@clairernovotny do u want to proceed with this?