Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Titleize removing decimal point #1267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ltwo3five
Copy link

…ed logic to remove more than one decimal points if it occurs in a double

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@SimonCropp SimonCropp changed the title fixes #1261 Fix Titlize removes decimal point Feb 13, 2024
@SimonCropp SimonCropp added this to the v3.0 milestone Feb 13, 2024
@SimonCropp SimonCropp enabled auto-merge (squash) February 13, 2024 10:15
@SimonCropp
Copy link
Collaborator

thanks for the contribution

@SimonCropp
Copy link
Collaborator

@Ltwo3five you need to sign the cla

@hazzik hazzik changed the title Fix Titlize removes decimal point Fix Titleize removing decimal point Feb 20, 2024
@SimonCropp
Copy link
Collaborator

@Ltwo3five can you rebase

auto-merge was automatically disabled February 20, 2024 15:58

Head branch was pushed to by a user without write access

…ed logic to remove more than one decimal points if it occurs in a double
@Ltwo3five
Copy link
Author

@dotnet-policy-service agree

@hazzik
Copy link
Member

hazzik commented Feb 22, 2024

@Ltwo3five it seems something still has gone wrong. Could you please rebase again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants