Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time format less resources #1184

Closed
wants to merge 3 commits into from

Conversation

neilboyd
Copy link
Contributor

@neilboyd neilboyd commented Feb 25, 2022

This PR is a work in progress. Comments are welcome to help guide the progress.

Use double formatting as suggested in #571 (comment) in order to reduce the number of translated string resources needed for #1183

Put this on hold because there's a lot more to do, and maybe it's not even helping for #1183, so I'll get back to that.


Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@neilboyd neilboyd mentioned this pull request Feb 25, 2022
11 tasks
@neilboyd neilboyd force-pushed the time-format-less-resources branch 2 times, most recently from 90558f1 to 16135a6 Compare February 27, 2022 22:03
@neilboyd
Copy link
Contributor Author

neilboyd commented Mar 4, 2022

I will not do this as a predecessor to #1183. Could still do it afterwards, but that's another story.

@neilboyd neilboyd closed this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant