Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings #1176

Merged
merged 1 commit into from Feb 18, 2022
Merged

fix warnings #1176

merged 1 commit into from Feb 18, 2022

Conversation

neilboyd
Copy link
Contributor

@neilboyd neilboyd commented Feb 8, 2022

Fix build warnings so that the CI build is clean.


Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

Comment on lines -19 to -20
/// <param name="count">Number of units, default is One.</param>
/// <param name="toWords">Result to words, default is false.</param>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was introduced in #1106

@@ -1,8 +1,18 @@
namespace Humanizer
{
/// <summary>
/// Options for specifying readable clock notation
/// </summary>
public enum ClockNotationRounding
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was introduced in #1134

@neilboyd neilboyd force-pushed the fix-warnings branch 2 times, most recently from 34f5b89 to 4b2967b Compare February 8, 2022 08:00
@neilboyd neilboyd marked this pull request as ready for review February 18, 2022 06:06
@clairernovotny clairernovotny merged commit 3e79379 into Humanizr:main Feb 18, 2022
@neilboyd neilboyd deleted the fix-warnings branch February 18, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants