Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize ByteRate humanization #1108

Merged
merged 3 commits into from Oct 27, 2021
Merged

Localize ByteRate humanization #1108

merged 3 commits into from Oct 27, 2021

Commits on Oct 27, 2021

  1. Add ByteRateTests that should be fulfilled

    @hangy
    hangy committed Oct 27, 2021
    Copy the full SHA
    02db6cd View commit details
    Browse the repository at this point in the history

  2. Update English ByteRate tests to reflect current TimeUnit translations

    @hangy
    hangy committed Oct 27, 2021
    Copy the full SHA
    499ba50 View commit details
    Browse the repository at this point in the history

  3. Implement localized version of ByteRate.Humanize() 

    This used TimeUnit.ToSymbol() as it's underlying localization, so that
it only needs to be done once.
    @hangy
    hangy committed Oct 27, 2021
    Copy the full SHA
    925d758 View commit details
    Browse the repository at this point in the history