Merge pull request #1114 from YohDeadfall/fix-default-number-format

Humanizr · Oct 29, 2021 · aea2bf9 · aea2bf9
2 parents ee0b9ad + 7f86099
commit aea2bf9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/Humanizer.Tests.Shared/Bytes/ByteRateTests.cs b/src/Humanizer.Tests.Shared/Bytes/ByteRateTests.cs
@@ -47,7 +47,7 @@ public void TimeUnitTests(long megabytes, double measurementIntervalSeconds, Tim
         }
 
         [Theory]
-        [InlineData(19854651984, 1, TimeUnit.Second, null, "18.4910856038332 GB/s")]
+        [InlineData(19854651984, 1, TimeUnit.Second, null, "18.49 GB/s")]
         [InlineData(19854651984, 1, TimeUnit.Second, "#.##", "18.49 GB/s")]
         public void FormattedTimeUnitTests(long bytes, int measurementIntervalSeconds, TimeUnit displayInterval, string format, string expectedValue)
         {

diff --git a/src/Humanizer.Tests.Shared/Bytes/ToStringTests.cs b/src/Humanizer.Tests.Shared/Bytes/ToStringTests.cs
@@ -37,6 +37,7 @@ public void ReturnsLargestMetricSuffix()
         [Fact]
         public void ReturnsDefaultNumberFormat()
         {
+            Assert.Equal("10.5 KB", ByteSize.FromKilobytes(10.501).ToString());
             Assert.Equal("10.5 KB", ByteSize.FromKilobytes(10.5).ToString("KB"));
         }
 

diff --git a/src/Humanizer/Bytes/ByteSize.cs b/src/Humanizer/Bytes/ByteSize.cs
@@ -228,7 +228,7 @@ public string ToString(IFormatProvider provider)
             if (provider == null)
                 provider = CultureInfo.CurrentCulture;
 
-            return string.Format("{0} {1}", LargestWholeNumberValue.ToString(provider), GetLargestWholeNumberSymbol(provider));
+            return string.Format(provider, "{0:0.##} {1}", LargestWholeNumberValue, GetLargestWholeNumberSymbol(provider));
         }
 
         public string ToString(string format)