Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typing fixes #590

Merged
merged 1 commit into from Oct 25, 2022
Merged

Small typing fixes #590

merged 1 commit into from Oct 25, 2022

Conversation

ianyfan
Copy link
Contributor

@ianyfan ianyfan commented Oct 25, 2022

Description

This fixes some typing issues that arose on a fresh install:

This is a very small PR, so I can add more typing fixes where I notice them to add some more substance, if desired.

Testing

ci/code_checks.sh, which failed on a fresh install, now passes

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #590 (3883d10) into master (944edce) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          85       85           
  Lines        8105     8105           
=======================================
  Hits         7901     7901           
  Misses        204      204           
Impacted Files Coverage Δ
src/imitation/algorithms/preference_comparisons.py 99.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Small PRs are fine -- preferable, in fact, easy to review. 3 lines is admittedly on the smaller end of a small PR, but feel free to just send these across as they come up.

Not sure why pytype was failing for you bot not on CI; I'm guessing version issue? But adding NoReturn seems like the right thing to do regardless.

@AdamGleave AdamGleave merged commit 6ad161b into master Oct 25, 2022
@AdamGleave AdamGleave deleted the ianyfan/typing branch October 25, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants